Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure emitted method signatures have the correct generic parameter count #391

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Ensure emitted method signatures have the correct generic parameter count #391

merged 1 commit into from
Dec 12, 2024

Conversation

ds5678
Copy link
Contributor

@ds5678 ds5678 commented Dec 12, 2024

Previously, all method signatures were emitted as non-generic.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12288614352

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 28.15%
Changes Missing Coverage Covered Lines Changed/Added Lines %
Cpp2IL.Core/Model/Contexts/MethodAnalysisContext.cs 0 1 0.0%
Cpp2IL.Core/Utils/AsmResolver/ContextToMethodDescriptor.cs 0 2 0.0%
Cpp2IL.Core/Utils/AsmResolver/AsmResolverAssemblyPopulator.cs 0 3 0.0%
Totals Coverage Status
Change from base Build 12286738079: -0.004%
Covered Lines: 3385
Relevant Lines: 10280
💛 - Coveralls

@SamboyCoding SamboyCoding merged commit 4def87e into SamboyCoding:development Dec 12, 2024
6 checks passed
@ds5678 ds5678 deleted the generic-parameter-count branch December 12, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamboyCoding SamboyCoding SamboyCoding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ds5678 @coveralls @SamboyCoding